Mostly fixes #5528#5585
Draft
Tiggles wants to merge 9 commits into
Draft
Conversation
Collaborator
|
The provider branding requires the provider to have some configured, otherwise it will just return nothing as you have noted. I believe this is working as Dan intended. But we are probably missing some fallback as this PR implies 😅 The PR mostly looks fine to me, although I am not sure I understand the endpoint comment. Is it still supposed to be a draft? |
Contributor
Author
|
Response from I'm not sure how to use the UCloud "logo" value here. Currently, I think every logo usage uses the fallback values. Until that works for at least one provider, it should probably be a draft. |
Collaborator
|
I have created #5614 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses fallbacks value for logos that has
/in them. Not sure what endpoint these should be using.Example:
/ucloud/ucloud/provider/branding/image?name=provider_logo_e5cd953530d2c8ad6e4ad4fa86e80929f158bd602087f1add75e4c53d74c2905.pngI'm assuming it should just be rhs of the query parameters, but
/api/branding/image?name=<rhs>doesn't respond with anything.EDIT: Another thing:
The provider string in a drives specification (
drive.specification.product.provider) doesn't seem to have a match stored in the backend in some cases. What the frontend queries is["ucloud", "hippo", "aau", "aau-k8", "sdu-odense"], but the provider branding only has entries (but not necessarily filled) for["aau-k8", "sdu-odense", "ucloud"](Related #5559)